chore: Fix v1x tests #3828
Merged
chore: Fix v1x tests #3828
+115
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackupRSCloudBackupSchedule_copySettings
This reverts commit 35215b5.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes v1x test organization by renaming and relocating a test function to ensure all v1x migration tests run in the same test group. This prevents test failures in environments where v1.x providers don't have support (e.g., Service Accounts).
- Moved
TestMigBackupRSCloudBackupSchedule_copySettingsto a new v1x-specific test file and renamed it to follow v1x naming convention - Updated precheck functions to ensure proper test environment setup
- Modified CI workflow to include the relocated test in the v1x test group
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/testutil/mig/pre_check.go | Added PreCheckLast1XVersionSleep function combining v1x version check with sleep functionality |
| internal/service/cloudbackupschedule/resource_cloud_backup_schedule_migration_v1x_test.go | New file containing the relocated and renamed v1x test function |
| internal/service/cloudbackupschedule/resource_cloud_backup_schedule_migration_test.go | Removed the original test function and unused import |
| internal/service/advancedcluster/resource_migration_v1x_test.go | Updated precheck calls and cleaned up variable declarations |
| .github/workflows/acceptance-tests-runner.yml | Updated CI configuration to include cloudbackupschedule in v1x test packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
manupedrozo
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix v1x tests. Rename TestMigBackupRSCloudBackupSchedule_copySettings to TestV1xMigBackupRSCloudBackupSchedule_copySettings so it's run in
advanced_cluster_tpf_mig_from_sdkv2test group.In this way all v1x tests run in the same test group.
Before this PR it was run in the regular
backuptest group. For example the tests would fail for SA as v1.x providers don't support SA.Example of advanced_cluster executions for PAK and SA.
Type of change:
Required Checklist:
Further comments